[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make AC_COMPUTE_INT public

From: Paolo Bonzini
Subject: Re: [PATCH] Make AC_COMPUTE_INT public
Date: Wed, 28 Jun 2006 15:06:47 +0200
User-agent: Thunderbird (Macintosh/20060530)

First, AC_COMPUTE_INT doesn't need to have the exact same arguments
that _AC_COMPUTE_INT has.  If there's some extra argument that it
should have for public consumption, we can add it.
That's right, and that's what I did. The two parameters of AC_COMPUTE_INT are now the same as for AC_CACHE_CHECK. Note that the macros are m4_defun-ed, not AC_DEFUN-ed, to avoid failures in the testsuite from setting an empty variable. Anyway AC_COMPUTE_INT is tested by AC_CHECK_SIZEOF and AC_CHECK_ALIGNOF.
Second, I don't see why we can't compute the cache variable name from
the second argument of _AC_COMPUTE_INT.  That is a shell variable
name, and we can prepend ac_cv_whatever_ to it.
I think that's dangerous, because the same shell variable could be used in multiple invocations of _AC_COMPUTE_INT.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]