speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Use GLib's allocation functions consistently in src/server/*.c.


From: Andrei Kholodnyi
Subject: [PATCH] Use GLib's allocation functions consistently in src/server/*.c.
Date: Tue, 21 Sep 2010 10:56:58 +0200

I think you need to mention that you have removed spd_malloc and friends,
it is not clear from the patch description.

while applying your patch I got following trailing whitespace errors:

akholodn at proxima:~/wrgit/speechd.push$ git apply ~/mail1.txt
/home/akholodn/mail1.txt:434: trailing whitespace.
      SpeechdOptions.communication_method = g_strdup("unix_socket");
/home/akholodn/mail1.txt:470: trailing whitespace.
    return g_strdup(ERR_NOT_IMPLEMENTED);
/home/akholodn/mail1.txt:852: trailing whitespace.
            return g_strdup(ERR_INTERNAL);
/home/akholodn/mail1.txt:972: trailing whitespace.
            if (!strcmp(who, "all")) return
g_strdup(ERR_NOT_IMPLEMENTED);
/home/akholodn/mail1.txt:973: trailing whitespace.
            if (!isanum(who)) return g_strdup(ERR_NOT_A_NUMBER);
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.


not sure whether it belongs to this patch:
+    param = (char*) g_malloc0(bytes);
...
- strcpy(param,"");

instead of

+    param = (char*) g_malloc(bytes);
    assert(param != NULL);

    strcpy(param,"");



reply via email to

[Prev in Thread] Current Thread [Next in Thread]