speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add a missing prototype to festival_client.h.


From: Andrei . Kholodnyi
Subject: [PATCH] Add a missing prototype to festival_client.h.
Date: Thu, 09 Sep 2010 19:52:34 +0000

> > The separation should be as written in the file headers:
> > festival.c -- festival module
> > festival_client.c -- access to festival over TCP wrapped in C API

> Ok. Maybe I jumped the gun in committing Andrei's festival patch
> yesterday. He moved festivalGetVoices from festival_client.c to
> festival.c. This is the only function which calls lisp_list_get_vect,
> so if lisp_list_get_vect should be private to festival_client.c, then
> festivalGetVoices needs to move again.

based on the definition given above
VoiceDescription** festivalGetVoices has nothing to do with the access to  
the festival over TCP
and shall be located in festival.c similar to all getVoices functions from  
other modules.

Let us be pragmatic here.
The goal of this series was not clean up of the modules itself,
but rather removal of #include <.c> statements.

Could I just commit your patch, Chris? :D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100909/64453f63/attachment.htm>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]