speechd-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Add a missing prototype to festival_client.h.


From: William Hubbs
Subject: [PATCH] Add a missing prototype to festival_client.h.
Date: Thu, 9 Sep 2010 09:30:09 -0500

On Thu, Sep 09, 2010 at 03:43:31PM +0200, Andrei Kholodnyi wrote:
> On Thu, Sep 9, 2010 at 3:23 AM, Christopher Brannon
> <cmbrannon79 at gmail.com> wrote:
> > We need a prototype for lisp_list_get_vec in festival_client.h,
> > since festival_client.c exports this function.
> 
> Hi Chris,
> 
> I think it should other way around,
> i.e. function lisp_list_get_vec shall be moved to festival.c, since it
> is used only there.
> I'll send a patch for it.

-1

I think we need to be careful here, because festival_client.c/.h isn't
speech-dispatcher code and someone else holds the copyright for it.

I would tend to be cautious about deleting functions from
festival_client.c and putting them in festival.c for that reason.

William

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: 
<http://lists.freebsoft.org/pipermail/speechd/attachments/20100909/4a895754/attachment.pgp>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]