[PATCH] Add a missing prototype to festival_client.h.

[Hynek Hanke]

On 9.9.2010 15:43, Andrei Kholodnyi wrote:
> On Thu, Sep 9, 2010 at 3:23 AM, Christopher Brannon
> <cmbrannon79 at gmail.com>  wrote:
>    
>> We need a prototype for lisp_list_get_vec in festival_client.h,
>> since festival_client.c exports this function.
>>      
> I think it should other way around,
> i.e. function lisp_list_get_vec shall be moved to festival.c, since it
> is used only there.
>    

Well, all of the functions of festival_client.c are (directly
or indirectly) only used in festival.c. This in itself doesn't constitute
a reason to blend the two files together.

The separation should be as written in the file headers:
     festival.c -- festival module
     festival_client.c -- access to festival over TCP wrapped in C API

Maybe it would further be further useful to separate festival_client.c
into two components:
     1/ the text protocol wrapped in C API
     2/ actual access over TCP (connection handling etc)
This would be useful, because we could then alternatively
run festival as subprocess and access it via pipe (perhaps faster
and not having to rely on an external server). A problem
with this separation however is, that some of the lisp commands
behave differently in server mode.

Back to the separation we have now, I think lisp_list_get_vec
actually belongs to festival_client.c and I think should be a private
function of it.

About the other things:

The former code of festival_client.c was modified extensively. Partly,
because there were problems with the sample implementation and also
because of the new festival-freebsoft-utils intermediate layer. 
Fortunatelly,
the license is very very open. We only need to keep the message, which
is perfectly correct.

Best regards,
Hynek Hanke