Re: [Sks-devel] Screen corruption on current CVS (op=index)

[Yaron M. Minsky]

I don't get it.  What does that diff signify?

Anyway, I do have the fix.  It's in CVS, and the key portion of the
patch is shown below.  You can check out sks.dnsalias.net to see what
the working code looks like.

y


===================================================================
RCS file: /cvsroot/sks/sks/index.ml,v
retrieving revision 1.9
diff -c -r1.9 index.ml
*** index.ml    1 Feb 2004 17:51:19 -0000       1.9
--- index.ml    25 Feb 2004 03:09:04 -0000
***************
*** 577,583 ****
      let uids = move_primary_to_front ~keyid uids in
  
      let userids = List.map ~f:(fun (uid,sigs) -> 
!                                HtmlTemplates.html_quote uid.packet_body) uids 
      in
      let userids = match userids with [] -> []
        | hd::tl -> (sprintf "<a href=\"%s\">%s</a>" ilink hd)::tl in
--- 577,588 ----
      let uids = move_primary_to_front ~keyid uids in
  
      let userids = List.map ~f:(fun (uid,sigs) -> 
!                                match uid.packet_type with
!                                    User_ID_Packet -> HtmlTemplates.html_quote 
uid.packet_body
!                                  | User_Attribute_Packet -> "[user attribute 
packet]"
!                                  | _ -> "[unexpected packet type]"
!                             )
!                   uids 
      in
      let userids = match userids with [] -> []
        | hd::tl -> (sprintf "<a href=\"%s\">%s</a>" ilink hd)::tl in


On Tue, 2004-02-24 at 20:12, Jason Harris wrote:
> On Tue, Feb 24, 2004 at 05:40:50PM -0500, Yaron Minsky wrote:
> 
> > Yeah, that pretty much settles it.  I more or less know where the bug is. 
> > I'll track it down in the next few days.
> > 
> 
> You guys...  :(
> 
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> NotDashEscaped: You need GnuPG to verify this message
> 
> Index: index.ml
> ===================================================================
> RCS file: /cvsroot/sks/sks/index.ml,v
> retrieving revision 1.9
> diff -u -r1.9 index.ml
> --- index.ml  1 Feb 2004 17:51:19 -0000       1.9
> +++ index.ml  25 Feb 2004 01:09:10 -0000
> @@ -344,7 +344,6 @@
>      | User_ID_Packet -> 
>       sprintf "<b>uid</b> <font color=\"green\"><u>%s</u></font>" 
>       (HtmlTemplates.html_quote uid.packet_body)
> -
>      | _ -> sprintf "<b>uat</b> [contents omitted]"
>    in
>    let creation_string = datestr_of_int64 in
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (FreeBSD)
> 
> iD8DBQFAO/XrSypIl9OdoOMRAunlAJ43Kf2vXkdzKpzMpLzX8ag4iGkLggCdGEX+
> P+iglTL9xuBSbI+qpOFNVe0=
> =eArq
> -----END PGP SIGNATURE-----
-- 
|--------/            Yaron M. Minsky              \--------|
|--------\ http://www.cs.cornell.edu/home/yminsky/ /--------|

Open PGP --- KeyID B1FFD916
Fingerprint: 5BF6 83E1 0CE3 1043 95D8 F8D5 9F12 B3A9 B1FF D916