Re: [Simulavr-devel] Re: interrupt flag/enable bits update

[John Regehr]

>   if ((read (irq->enable.addr) & irq->enable.mask)

Just to document the idiom here I'd wrap this in a little function that'll
get inlined:

  int int_bit_set (IntBit intbit) {
    return ((read (intbit.addr) & intbit.mask) != 0);
  }

> I'm hoping that you are thinking about something like this for
> avr_core_check_interrupts():
>
>   if ((read (irq->enable.addr) & irq->enable.mask)
>       && ((irq->flag.mask == 0) ||
>           (read (irq->flag.addr) & irq->flag.mask)))
>   {
>       uint8_t clr_flag = read (irq->flag.addr) & ~irq->flag.mask;
>
>       /* vector in the irq */
>
>       write (irq->flag.addr, clf_flag);
>   }

Yes, that is what I was thinking.

John