[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() |
Date: |
Fri, 27 May 2016 13:07:36 +1000 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote:
>
>
> On 12/05/2016 05:48, Bharata B Rao wrote:
> > CPUState *cpu gets added to the cpus list during cpu_exec_init(). It
> > should be removed from cpu_exec_exit().
> >
> > cpu_exec_exit() is called from generic CPU::instance_finalize and some
> > archs like PowerPC call it from CPU unrealizefn. So ensure that we
> > dequeue the cpu only once.
>
> I think the better thing would be to call it from CPU::unrealize, but
> this patch is okay too.
>
> Thanks,
>
> Paolo
Thanks for the review Paolo.
However, what I'm really unclear on is what is the next step towards
merging these. Will you take them through your tree? Should Bharata
send a formal pull request with the prelim patches? If so, to whom?
> > Now -1 value for cpu->cpu_index indicates that we have already dequeued
> > the cpu for CONFIG_USER_ONLY case also.
> >
> > Signed-off-by: Bharata B Rao <address@hidden>
> > Reviewed-by: David Gibson <address@hidden>
> > Reviewed-by: Thomas Huth <address@hidden>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects, (continued)
[Qemu-ppc] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 09/15] spapr: CPU hotplug support, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 10/15] xics, xics_kvm: Handle CPU unplug correctly, Bharata B Rao, 2016/05/11
[Qemu-ppc] [for-2.7 PATCH v3 15/15] spapr: implement query-hotpluggable-cpus callback, Bharata B Rao, 2016/05/12
[Qemu-ppc] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type, Bharata B Rao, 2016/05/12