[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit() |
Date: |
Thu, 26 May 2016 12:22:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 12/05/2016 05:48, Bharata B Rao wrote:
> cpu_exec_init() does vmstate_register for the CPU device. This needs to be
> undone from cpu_exec_exit(). This change is needed to support CPU hot
> removal.
>
> Signed-off-by: Bharata B Rao <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> ---
> exec.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/exec.c b/exec.c
> index da1f09a..32bd5df 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -635,6 +635,8 @@ static void cpu_release_index(CPUState *cpu)
>
> void cpu_exec_exit(CPUState *cpu)
> {
> + CPUClass *cc = CPU_GET_CLASS(cpu);
> +
> #if defined(CONFIG_USER_ONLY)
> cpu_list_lock();
> #endif
> @@ -652,6 +654,13 @@ void cpu_exec_exit(CPUState *cpu)
> #if defined(CONFIG_USER_ONLY)
> cpu_list_unlock();
> #endif
> +
> + if (cc->vmsd != NULL) {
> + vmstate_unregister(NULL, cc->vmsd, cpu);
> + }
> + if (qdev_get_vmsd(DEVICE(cpu)) == NULL) {
> + vmstate_unregister(NULL, &vmstate_cpu_common, cpu);
> + }
> }
>
> void cpu_exec_init(CPUState *cpu, Error **errp)
>
Acked-by: Paolo Bonzini <address@hidden>
- [Qemu-ppc] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, (continued)
- [Qemu-ppc] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2016/05/11
- Re: [Qemu-ppc] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit(),
Paolo Bonzini <=
- [Qemu-ppc] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 09/15] spapr: CPU hotplug support, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 10/15] xics, xics_kvm: Handle CPU unplug correctly, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 15/15] spapr: implement query-hotpluggable-cpus callback, Bharata B Rao, 2016/05/12
- [Qemu-ppc] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type, Bharata B Rao, 2016/05/12
- [Qemu-ppc] [for-2.7 PATCH v3 14/15] hmp: Add 'info hotpluggable-cpus' HMP command, Bharata B Rao, 2016/05/12
- Re: [Qemu-ppc] [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR, Thomas Huth, 2016/05/25