[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-ppc] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects |
Date: |
Thu, 26 May 2016 16:17:36 +0530 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, May 26, 2016 at 12:19:05PM +0200, Paolo Bonzini wrote:
>
>
> On 12/05/2016 05:48, Bharata B Rao wrote:
> > @@ -1531,6 +1563,9 @@ static void tcg_exec_all(void)
> > break;
> > }
> > } else if (cpu->stop || cpu->stopped) {
> > + if (cpu->unplug) {
>
> This "if" is unnecessary. next_cpu is not used anymore after the
> "break", so the store is dead.
next_cpu is a global here. Won't tcg_exec_all() continue with running the
next_cpu when it is called the next time ?
Regards,
Bharata.
- [Qemu-ppc] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR, Bharata B Rao, 2016/05/11
- [Qemu-ppc] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit(), Bharata B Rao, 2016/05/11