Re: [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> This patch merely changes the interface, aborting on all failures,

You say this but...

<snip>
>
> -static inline void tcg_out_mov(TCGContext *s, TCGType type,
> +static inline bool tcg_out_mov(TCGContext *s, TCGType type,
>                                 TCGReg ret, TCGReg arg)
>  {
> -    tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, SHIFT_IMM_LSL(0));
> +    if (ret != arg) {
> +        tcg_out_dat_reg(s, COND_AL, ARITH_MOV, ret, 0, arg, 
> SHIFT_IMM_LSL(0));
> +    }
> +    return true;
>  }

You fix a mov folding here.. either mention in commit message or fix in
a separate commit. I appreciate the other arches already do this.

Otherwise:

Reviewed-by: Alex Bennée <address@hidden>

--
Alex Bennée