[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qe
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() |
|
Date: |
Wed, 1 May 2019 13:26:59 -0400 |
|
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On Tue, Apr 30, 2019 at 07:48:16PM -0300, Eduardo Habkost wrote:
> On Tue, Apr 30, 2019 at 10:36:18PM +0000, Wei Yang wrote:
> [...]
> > >> +#ifdef CONFIG_LINUX
> > >> +#include <linux/mman.h>
> > >> +#endif /* CONFIG_LINUX */
> > >> +
> > >> +#ifndef MAP_SYNC
> > >> +#define MAP_SYNC 0
> > >> +#endif
> > >> +#ifndef MAP_SHARED_VALIDATE
> > >> +#define MAP_SHARED_VALIDATE 0
> > >> +#endif
> > >
> > >Why would we need this, if we added copies of mman.h to
> > >linux-headers?
> >
> > This is reported by Stefan.
> >
> > https://www.mail-archive.com/address@hidden/msg612168.html
>
> Stefan, did you hit a build failure, or it was just theoretical?
>
> linux-headers/*/mman.h is updated by "linux-headers: add
> linux/mman.h" (commit 8cf108c5d159). If the build really fails,
> something else is broken in our build system.
I wasn't aware that QEMU ships its own mman.h. In that case we don't
need the ifndef for Linux hosts.
Stefan
signature.asc
Description: PGP signature