[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties |
Date: |
Tue, 30 Sep 2014 10:46:26 +0200 |
On Tue, 30 Sep 2014 14:10:31 +0800
<address@hidden> wrote:
> From: Gonglei <address@hidden>
>
> virtio-serial-{pci, s390, ccw} all duplicate the
> qdev properties of their VirtIOSerial child.
> This approach does not work well with string or pointer
> properties since we must be careful about leaking or
> double-freeing them.
>
> Use the QOM alias property to forward property accesses to the
> VirtIOSerial child. This way no duplication is necessary.
>
> Signed-off-by: Gonglei <address@hidden>
> ---
> hw/s390x/s390-virtio-bus.c | 2 +-
> hw/s390x/virtio-ccw.c | 2 +-
> hw/virtio/virtio-pci.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties, (continued)
- [Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 09/12] virtio-balloon: fix virtio-balloon child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- Re: [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties,
Cornelia Huck <=
- [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization, arei.gonglei, 2014/09/30
- Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization, Markus Armbruster, 2014/09/30
[Qemu-devel] [PATCH v2 02/12] virtio-net: fix virtio-net child refcount in transports, arei.gonglei, 2014/09/30