[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in
From: |
arei.gonglei |
Subject: |
[Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in transports |
Date: |
Tue, 30 Sep 2014 14:10:37 +0800 |
From: Gonglei <address@hidden>
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is
dropped again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon
unplug the virtio-9p child is not finalized!
Drop our reference after the child property has been added to the
parent.
Signed-off-by: Gonglei <address@hidden>
---
hw/virtio/virtio-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 714286d..8f3b79b 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -950,6 +950,7 @@ static void virtio_9p_pci_instance_init(Object *obj)
object_initialize(&dev->vdev, sizeof(dev->vdev), TYPE_VIRTIO_9P);
object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL);
qdev_alias_all_properties(DEVICE(&dev->vdev), obj);
+ object_unref(OBJECT(&dev->vdev));
}
static const TypeInfo virtio_9p_pci_info = {
--
1.7.12.4
- [Qemu-devel] [PATCH v2 01/12] virtio-net: use aliases instead of duplicate qdev properties, (continued)
- [Qemu-devel] [PATCH v2 01/12] virtio-net: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 06/12] virtio-serial: fix virtio-serial child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 08/12] virtio-rng: fix virtio-rng child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 03/12] virtio/vhost-scsi: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 04/12] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 11/12] virtio-9p: fix virtio-9p child refcount in transports,
arei.gonglei <=
- [Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 09/12] virtio-balloon: fix virtio-balloon child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization, arei.gonglei, 2014/09/30