[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backe
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization |
Date: |
Tue, 30 Sep 2014 11:17:29 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 |
Il 30/09/2014 11:04, Cornelia Huck ha scritto:
> On Tue, 30 Sep 2014 14:10:38 +0800
> <address@hidden> wrote:
>
>> From: Gonglei <address@hidden>
>>
>> For better code sharing, add a wrapper help funciton
>
> typo: s/funciton/function/
>
>> for various virtio devices.
>
> s/for various virtio devices/that handles referencing the virtio
> backend for virtio proxy devices/ ?
>
>>
>> Cc: Cornelia Huck <address@hidden>
>> Cc: Michael S. Tsirkin <address@hidden>
>> Signed-off-by: Gonglei <address@hidden>
>> ---
>> hw/s390x/s390-virtio-bus.c | 42 +++++++++++++++++----------------------
>> hw/s390x/virtio-ccw.c | 42 +++++++++++++++++----------------------
>> hw/virtio/virtio-pci.c | 49
>> ++++++++++++++++++++--------------------------
>> hw/virtio/virtio.c | 11 +++++++++++
>> include/hw/virtio/virtio.h | 3 +++
>> 5 files changed, 71 insertions(+), 76 deletions(-)
>
> I'm wondering whether we should call the wrapper for virtio-balloon as
> well. Even if it does not have any properties to alias, calling
> qdev_alias_all_properties() probably doesn't hurt, does it?
Actually it has properties to alias: guest-stats and
guest-stats-polling-interval are effectively aliases,
so we could remove 30-odd lines of code from virtio-pci
and virtio-ccw. It's okay IMO to put it in a separate patch,
since it is a bit different from the trivial replacement
done here.
Paolo
- [Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties, (continued)
- [Qemu-devel] [PATCH v2 07/12] virtio-rng: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 09/12] virtio-balloon: fix virtio-balloon child refcount in transports, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
- [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization, arei.gonglei, 2014/09/30
- Re: [Qemu-devel] [PATCH v2 12/12] virtio: add a wrapper for virtio-backend initialization, Markus Armbruster, 2014/09/30
[Qemu-devel] [PATCH v2 02/12] virtio-net: fix virtio-net child refcount in transports, arei.gonglei, 2014/09/30
[Qemu-devel] [PATCH v2 10/12] virtio-9p: use aliases instead of duplicate qdev properties, arei.gonglei, 2014/09/30
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports, Cornelia Huck, 2014/09/30
Re: [Qemu-devel] [PATCH v2 00/12] virtio: fix virtio child recount in transports, Paolo Bonzini, 2014/09/30