[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements |
Date: |
Fri, 16 Nov 2012 12:04:19 +0100 |
Instead of playing with bit shifting, add two unions (one for 32-bit
values, one for 64-bit ones) to access all the DSP elements with the
correct type.
This make the code easier to read and less error prone, and allow GCC
to vectorize the code in some cases.
Signed-off-by: Aurelien Jarno <address@hidden>
---
target-mips/dsp_helper.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index e7949c2..8015d8d 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -20,6 +20,28 @@
#include "cpu.h"
#include "helper.h"
+/* As the byte ordering doesn't matter, i.e. all columns are treated
+ identically, these unions can be used directly. */
+typedef union {
+ uint8_t ub[4];
+ int8_t sb[4];
+ uint16_t uh[2];
+ int16_t sh[2];
+ uint32_t uw[1];
+ int32_t sw[1];
+} DSP32Value;
+
+typedef union {
+ uint8_t ub[8];
+ int8_t sb[8];
+ uint16_t uh[4];
+ int16_t sh[4];
+ uint32_t uw[2];
+ int32_t sw[2];
+ uint64_t ul[1];
+ int64_t sl[1];
+} DSP64Value;
+
/*** MIPS DSP internal functions begin ***/
#define MIPSDSP_ABS(x) (((x) >= 0) ? x : -x)
#define MIPSDSP_OVERFLOW(a, b, c, d) (!(!((a ^ b ^ -1) & (a ^ c) & d)))
--
1.7.10.4
- [Qemu-devel] [PATCH 0/7] target-mips: DSP ASE fixes and cleanup, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 1/7] target-mips: fix DSP loads with rd = 0, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for reduction add instructions, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 2/7] target-mips: generate a reserved instruction exception on CPU without DSP, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 5/7] target-mips: use DSP unions for unary DSP operators, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators, Aurelien Jarno, 2012/11/16
- [Qemu-devel] [PATCH 7/7] target-mips: implement DSP (d)append sub-class with TCG, Aurelien Jarno, 2012/11/16