[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/6] arm: move neon_tbl to neon_helper.c
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 1/6] arm: move neon_tbl to neon_helper.c |
Date: |
Mon, 19 Mar 2012 22:10:57 +0000 |
On 19 March 2012 21:56, Blue Swirl <address@hidden> wrote:
> -DEF_HELPER_4(neon_tbl, i32, i32, i32, i32, i32)
> +DEF_HELPER_5(neon_tbl, i32, env, i32, i32, i32, i32)
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -6340,7 +6340,7 @@ static int disas_neon_data_insn(CPUARMState *
> env, DisasContext *s, uint32_t ins
> tmp2 = neon_load_reg(rm, 0);
> tmp4 = tcg_const_i32(rn);
> tmp5 = tcg_const_i32(n);
> - gen_helper_neon_tbl(tmp2, tmp2, tmp, tmp4, tmp5);
> + gen_helper_neon_tbl(cpu_env, tmp2, tmp2, tmp, tmp4, tmp5);
> tcg_temp_free_i32(tmp);
> if (insn & (1 << 6)) {
> tmp = neon_load_reg(rd, 1);
> @@ -6349,7 +6349,7 @@ static int disas_neon_data_insn(CPUARMState *
> env, DisasContext *s, uint32_t ins
> tcg_gen_movi_i32(tmp, 0);
> }
> tmp3 = neon_load_reg(rm, 1);
> - gen_helper_neon_tbl(tmp3, tmp3, tmp, tmp4, tmp5);
> + gen_helper_neon_tbl(cpu_env, tmp3, tmp3, tmp, tmp4, tmp5);
> tcg_temp_free_i32(tmp5);
> tcg_temp_free_i32(tmp4);
> neon_store_reg(rd, 0, tmp2);
...shouldn't these be
gen_helper_neon_tbl(tmp3, cpu_env, tmp3, tmp, tmp4, tmp5);
?
-- PMM