qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset
Date: Sun, 02 Oct 2011 15:50:07 -0400 (EDT)

> > 
> > Why not use an ordinary qemu_irq?  It reresents a pin; 0->1 edge
> > (assert) enters phase 1, 1->0 edge (deassert) enters phase 2.
> >  Exactly like real hardware.
> 
> QEMU makes no difference between power-on reset and system reset
> right
> now. At least I am not aware of any device model that has problems
> with
> this. Thus there is apparently no need to treat reset and create
> differently. As QOM requires a two-phase device creation anyway (to
> let
> properties to "settle"), it looks like there is some reuse potential.
> 

I'm all for sharing this.  But let's model it as a qemu_irq or Pin.

btw, we could have qemu_irqs that take an extra qemu_irq reset input, so we can 
do this without much coding.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]