[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset |
Date: |
Sun, 02 Oct 2011 15:07:52 -0400 (EDT) |
> >
> > The way to fix it is two-phase reset:
> >
> > phase 1: reset internal state (-> move all outputs to reset
> > values),
> > don't sample inputs yet
> > phase 2: allow sampling inputs
>
> As far as I understood Anthony's QOM plans, phase 1 will correspond
> to
> "unrealize", phase 2 to "realize".
That smells of abusing mechanism used for construction for reset purposes.
Why not use an ordinary qemu_irq? It reresents a pin; 0->1 edge (assert)
enters phase 1, 1->0 edge (deassert) enters phase 2. Exactly like real
hardware.
>
> However, we do not depend on two phases in this particular case
> (i8259)
> and can live with a coalescing both for now.
>
Agree.
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, (continued)
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Paolo Bonzini, 2011/10/03
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/04
Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Peter Maydell, 2011/10/01
Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Avi Kivity, 2011/10/02
- Re: [Qemu-devel] [PATCH 11/22] i8259: Update IRQ state after reset, Blue Swirl, 2011/10/02