[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses
From: |
Blue Swirl |
Subject: |
Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses |
Date: |
Mon, 6 Oct 2008 18:56:14 +0300 |
On 10/6/08, Robert Reif <address@hidden> wrote:
> Blue Swirl wrote:
>
> > On 10/2/08, Robert Reif <address@hidden> wrote:
> >
> >
> > > #ifdef TARGET_SPARC
> > > + do_unassigned_access(addr, 0, 0, 0, 1);
> > > +#elif defined(TARGET_CRIS)
> > > do_unassigned_access(addr, 0, 0, 0);
> > > +#endif
> > > + return 0;
> > >
> > >
> >
> > I think it would be cleaner solution to convert also CRIS and MIPS
> > versions to take the size argument.
Is this patch OK for CRIS and MIPS too? The extra parameter should not hurt.