Re: [Qemu-devel] [PATCH] sparc: show size for unassigned accesses

[Edgar E. Iglesias]

On Mon, Oct 06, 2008 at 06:56:14PM +0300, Blue Swirl wrote:
> On 10/6/08, Robert Reif <address@hidden> wrote:
> > Blue Swirl wrote:
> >
> > > On 10/2/08, Robert Reif <address@hidden> wrote:
> > >
> > >
> > > >  #ifdef TARGET_SPARC
> > > >  +    do_unassigned_access(addr, 0, 0, 0, 1);
> > > >  +#elif defined(TARGET_CRIS)
> > > >     do_unassigned_access(addr, 0, 0, 0);
> > > >  +#endif
> > > >  +    return 0;
> > > >
> > > >
> > >
> > > I think it would be cleaner solution to convert also CRIS and MIPS
> > > versions to take the size argument.
> 
> Is this patch OK for CRIS and MIPS too? The extra parameter should not hurt.

It doesn't hurt for CRIS.

Thanks