[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lynx-dev dev.16 patch 3 - HTMIME.c, HTTP.c redirection (long)

From: Leonid Pauzner
Subject: Re: lynx-dev dev.16 patch 3 - HTMIME.c, HTTP.c redirection (long)
Date: Sun, 5 Dec 1999 00:35:12 +0300 (MSK)

4-Dec-99 09:10 Klaus Weide wrote:

> * Save size for regular files in anchor structure (we did the stat() anyway),
>   it shows up on INFO page as Content-Length.  Also use it in partial display
>   mode to prevent the last call to HTDisplayPartial from HTFileCopy, since a
>   call to HText_pageDisplay will follow immediately.  (But note that nothing
>   important depends on the correct size; should it be wrong, we lose at most
>   one partial display screen update.  An equivalent suppression of the last
>   partial update for network protocols is not recommended, since (a) the size
>   is more unreliable and (b) the socket FIN may get delayed by the network.)

> Index: 2.30/WWW/Library/Implementation/HTFormat.c
> --- 2.30/WWW/Library/Implementation/HTFormat.c Sat, 04 Dec 1999 00:06:06 -0600
> +++ 2.30(w)/WWW/Library/Implementation/HTFormat.c Sat, 04 Dec 1999 01:59:43 
> -0600
> @@ -795,7 +807,9 @@
>       (*targetClass.put_block)(sink, input_buffer, status);
>       bytes += status;
>       HTReadProgress(bytes, 0);
> -     HTDisplayPartial();
> +     if (NumOfLines_partial >= 0 && HTMainText && HTMainAnchor &&
> +         bytes != HTMainAnchor->content_length)
> +         HTDisplayPartial();

>       if (HTCheckForInterrupt()) {
>           _HTProgress (TRANSFER_INTERRUPTED);

That looks excessive, at least very strange as of dev16 changes
which enable partial mode right in HText_new() so first three
conditions are not required and the forth looks rather potetical.

Also, display_page() were hacked by you to redisplay only those lines
which were not displayed in partial mode yet so the next repaint from
mainloop will not make any harm.

Instead, that may be a good idea to add a true content_length to
HTReadProgress() call which may be useful for large files.
Of cause, that should not be HTMainAnchor reference but
a reference to anchor from some other place.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]