[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting pa
From: |
address@hidden |
Subject: |
Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10? |
Date: |
Fri, 8 Feb 2013 20:08:59 +0100 |
On 8 févr. 2013, at 18:58, address@hidden wrote:
> On 8 févr. 2013, at 18:24, David Kastrup <address@hidden> wrote:
>
>> "address@hidden" <address@hidden> writes:
>>
>>> On 8 févr. 2013, at 16:57, Xavier Scheuer <address@hidden> wrote:
>>>
>>>> On 8 February 2013 09:27, address@hidden <address@hidden> wrote:
>>>>>
>>>>> (snip)
>>>>>
>>>>> It's gonna take me some time to have a look at it - I'll do my best
>>>>> to check it out on Sunday.
>>>>
>>>> Is this related to the not-yet-added-to-the-tracker "chord name collide
>>>> with staff" issue?
>>>> http://lists.gnu.org/archive/html/bug-lilypond/2013-02/msg00019.html
>>>>
>>>> Should Trevor's report be added to the tracker?
>>>>
>>>> Cheers,
>>>> Xavier
>>>
>>> The two problems are related but not identical. The problem here is
>>> that skyline.cc uses an EPS value to weed out too-tiny buildings.
>>
>> Why? A building of height exactly zero is not empty (this corresponds
>> to point-stencil). Emptiness is signaled by an interval with the upper
>> boundary being below the lower boundary.
>
> I believe that the presence of EPS dates back to 2007 in some of Joe's
> skyline work. I'm assuming it exists to speed up skyline calculations, but
> it'd be best to get the response straight from him.
>
> Cheers,
> MS
Just ran the regtests...with the simple patch below, there are significant
differences in the figured-bass.ly regtest and tablature-repeat.ly regtest.
It'll take me some time to figure out why EPS has an influence on these things,
and I have work all weekend. Any help would be appreciated!
Cheers,
MS
diff --git a/lily/skyline.cc b/lily/skyline.cc
index ed5f390..a75093c 100644
--- a/lily/skyline.cc
+++ b/lily/skyline.cc
@@ -329,7 +329,7 @@ empty_skyline (list<Building> *const ret)
static void
single_skyline (Building b, list<Building> *const ret)
{
- if (b.end_ > b.start_ + EPS)
+ if (b.end_ >= b.start_)
{
if (b.start_ != -infinity_f)
ret->push_back (Building (-infinity_f, -infinity_f,
@@ -475,8 +475,6 @@ Skyline::Skyline (Direction sky)
/*
Build skyline from a set of boxes.
-
- Boxes should have fatness in the horizon_axis, otherwise they are ignored.
*/
Skyline::Skyline (vector<Box> const &boxes, Axis horizon_axis, Direction sky)
{
@@ -487,7 +485,7 @@ Skyline::Skyline (vector<Box> const &boxes, Axis
horizon_axis, Direction sky)
for (vsize i = 0; i < boxes.size (); i++)
{
Interval iv = boxes[i][horizon_axis];
- if (iv.length () > EPS && !boxes[i][vert_axis].is_empty ())
+ if (!iv.is_empty () && !boxes[i][vert_axis].is_empty ())
buildings.push_front (Building (boxes[i], horizon_axis, sky));
}
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, (continued)
- Message not available
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Keith OHara, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Trevor Bača, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Xavier Scheuer, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?,
address@hidden <=
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/09
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/09
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Keith OHara, 2013/02/09
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, address@hidden, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Trevor Bača, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, David Kastrup, 2013/02/08
- Re: Did VerticalAxisGroup default-staff-staff-spacing stop respecting padding in 2.17.10?, Trevor Bača, 2013/02/08