lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't wrap EventChord around rhythmic events by default. (issue 5440


From: md5i . mail
Subject: Re: Don't wrap EventChord around rhythmic events by default. (issue 5440084)
Date: Fri, 20 Jan 2012 13:55:56 +0000


http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy
File lily/parser.yy (right):

http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy#newcode432
lily/parser.yy:432: %type <scm> list_music
I must *strongly* recommend that the name of either music_list or
list_music be changed.  Even if the names make distinct sense, it is far
to easy to transpose identifiers like this when reading or writing code.
 (I have made this mistake in my own code many times in the past.)
Given the existence of other _list types, I suggest that the name of
list_music be changed.  Maybe "wrapped_music" or "music_chord"...

http://codereview.appspot.com/5440084/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]