gnulib-tool-py
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnulib-tool-py] end-of-line conventions


From: Bruno Haible
Subject: [gnulib-tool-py] end-of-line conventions
Date: Fri, 04 May 2012 23:38 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Hi Dmitriy,

Nice to see that you added some unit tests already.

One remark here:
  if message_sh[-2:] == '\r\n':
    message_sh = message_sh.replace('\r\n', '\n')
  elif message_sh[-1] == '\r':
    message_sh = message_sh.replace('\r', '\n')

The first two lines are for Windows end-of-line conventions, clearly.
But the next two lines could only happen on MacOS 9 and earlier systems.
Such systems are not in use anymore nowadays. (In MacOS X Apple has
adopted the Unix end-of-line conventions.) IMO you can remove these two
lines.

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]