Re: [GNU Crypto] What to do with bugs?

[Raif S. Naffah]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

On Sun, 21 Sep 2003 12:01 pm, Raif S. Naffah wrote:
> On Sun, 21 Sep 2003 06:01 am, Mikael Hakman wrote:
> > ...
> > 1. gnu.crypto.jce.cipher.CipherAdapter
> >
> > engineUpdate(byte[] in, int inOff, int inLen, byte[] out, int
> > outOff)
> >
> > It does not update partBlock/partLen correctly when
> > inLen<blockSize. In particular when inLen=1 as is the case when
> > using JCE
> > CipherStreams only the very last block is processed. There are bugs
> > in several places in this function.

indeed this is a bug.

i checked in modified versions of both CipherAdapter and TestOfCipher. 
if you run 'make check' (or ant check) with the previous version of 
CipherAdapter you should get:

check:
     [echo] Choosing which classes to test...
     [echo] About to start Mauve tests. Patience...
    [mauve] javax.crypto.IllegalBlockSizeException: 8 trailing bytes
    [mauve]     at 
gnu.crypto.jce.cipher.CipherAdapter.engineDoFinal(CipherAdapter.java:408)
    [mauve]     at javax.crypto.Cipher.doFinal(Cipher.java:1267)
    [mauve]     at 
gnu.testlet.gnu.crypto.jce.TestOfCipher.testPartial(TestOfCipher.java:284)
    [mauve]     at 
gnu.testlet.gnu.crypto.jce.TestOfCipher.test(TestOfCipher.java:97)
    [mauve]     at 
gnu.testlet.SimpleTestHarness.runtest(SimpleTestHarness.java:219)
    [mauve]     at 
gnu.testlet.SimpleTestHarness.main(SimpleTestHarness.java:349)
    [mauve] FAIL: gnu.testlet.gnu.crypto.jce.TestOfCipher: 
testPartial(blowfish): javax.crypto.IllegalBlockSizeException: 8 
trailing bytes (number 1)

otherwise, if you checkout the new CipherAdapter class, all checks 
should run; i.e. (incl. Casey's latest checkins):

check:
     [echo] Choosing which classes to test...
     [echo] About to start Mauve tests. Patience...
    [mauve] 0 of 3947 tests failed


cheers;
rsn
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Que du magnifique

iD8DBQE/die7+e1AKnsTRiERA+E1AKCKnXj7H4JLcBtgqZPjYsOnPTBg9gCgqxoX
RrvdwME5Chd8zfkdNYTtdTk=
=WpGo
-----END PGP SIGNATURE-----