[Gnu-arch-users] Re: GNU Arch 2.0 -- first source

[Daniel James]

Thomas Lord wrote:
> *too much is too slow* -- although the 2.0 code isn't especially 
> optimized yet, it seems to be /hella snappy/.
>
> 2.0 is very much git influenced but it brings some (imo significant) 
> improvements to the table.

I'm looking forward to this - I've recently been using cogito for its 
speed, but missing arch. I've got some bug reports:

1 - revc_list_cwd doesn't close the directory. This causes problems for 
large trees. I've put the obvious patch at the end of this mail.

2 - When adding files trailing forward slashes aren't removed, which 
causes revc-commit to complain that the manifest is corrupt.

3 - Filenames in the manifest are stored in case-insensitive order, but 
revc-commit seems to expect them to be in case-sensitive order. I think 
this is causing revc_list_find_subdir to pick up more files than it 
should which results in the manifest being declared corrupt.

Daniel

diff -ru revc-0.0x0/revc/deps/list-cwd.c revc/revc/deps/list-cwd.c
--- revc-0.0x0/revc/deps/list-cwd.c     2005-07-08 20:45:49.000000000 +0100
+++ revc/revc/deps/list-cwd.c   2005-07-09 20:05:19.000000000 +0100
@@ -41,6 +41,8 @@
       *place = fname;
     }

+  safe_closedir (dir);
+
   *list_ret = answer;
   return 0;
 }