[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10
From: |
Juanma Barranquero |
Subject: |
Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) |
Date: |
Fri, 16 Nov 2012 18:36:19 +0100 |
On Fri, Nov 16, 2012 at 6:25 PM, Stefan Monnier
<address@hidden> wrote:
> Hmm... maybe advice-add's before and after advices should be different.
> Instead of before being like
> (lambda (&rest r) (apply FUNCTION r) (apply OLDFUN r))
> it should maybe be like
> (lambda (&rest r) (apply OLDFUN (apply FUNCTION r)))
> Or maybe this should be a new WHERE, which we could call `:filter-args',
> and we could have a corresponding `:filter-return'.
Well, having new WHEREs seems more flexible, assuming that
:filter-args is indeed the right thing to do for all "before"
defadvices.
Juanma
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), (continued)
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Ivan Kanis, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500),
Juanma Barranquero <=
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/18
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/18