[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10
From: |
Stefan Monnier |
Subject: |
Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) |
Date: |
Thu, 15 Nov 2012 09:39:14 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
>>>> With these changes, so far I can play with Emacs as before.
>>> Thanks, installed,
>> I tried it this morning and it's fixed. Thank you Stefan.
> Unfortunately called-interactively-p never returns non-nil while
> performing an advised command interactively.
Yes, called-interactively-p (and interactivep, of course) are pretty
sensitive beasts. The problem you mention was already present before,
tho it probably got a bit worse (it used to "only" affect uses of
called-interactively-p in the advised command, whereas it now also
affects uses in the advice themselves).
Stefan
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), (continued)
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Ivan Kanis, 2012/11/12
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/13
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/13
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/13
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/14
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Ivan Kanis, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500),
Stefan Monnier <=
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Katsumi Yamaoka, 2012/11/15
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Juanma Barranquero, 2012/11/16
- Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500), Stefan Monnier, 2012/11/18