Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500)

[Stefan Monnier]

> My current code can handle uses of called-interactively-p in
> after/before advice but not in around advice.  Problem is: all advices
> defined with `defadvice' are implemented as (advice-add foo :around ...)
> and indeed your "before" advice cannot be implemented as a (advice-add
> foo :before ...) because it modifies arguments.

Sorry, I was confused.  My code can handle your example just fine.
The problem comes when an around advice is added after your advice, at
which point your advice won't work any more (not because your is an
around advice, but because it's "hidden" by another around advice).
So a :filter-args thingy wouldn't make any difference in this respect.


        Stefan