[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Turn chicken.condition into a module, with

From: Evan Hanson
Subject: Re: [Chicken-hackers] [PATCH] Turn chicken.condition into a module, with syntax exports!
Date: Fri, 19 May 2017 13:10:03 +1200

Hi Peter,

On 2017-05-07 21:45, Peter Bex wrote:
> The core-library-reorganization page has "(chicken condition)" under
> "undecided", but I think it's fine the way it is.  The attached patches
> add this module.

These have been applied. Excellent work, it looks like these were tricky

> This time around, I minimised the number of ##sys# prefix removals,
> to avoid complicating things too much.  It's better to do that in
> another pass; this changeset is complicated enough as it is.

Thanks. This wasn't as tough to review as I'd expected, and that
certainly helped. Thank you also for explaining the workarounds for

I think before we strip many more qualified symbols we should come up
with an idea of how to handle their replacements. With that "escape
hatch" change, we can now do basically whatever we want, and we can even
(for example) get rid of the "internal" module (always a bit of a hack,
and one that I'd like to see go away...), in favor of direct assignments
to whatever namespace we decide to use.

On 2017-05-07 21:47, Peter Bex wrote:
> PS: before you run "make check", you'll need to install and recompile
> with the new compiler (or just go through a chicken-boot process),
> there are some issues with the static linking tests otherwise.

It was actually possible to compile this with the 5.0.0pre1 snapshot
directly, sans boot-chicken. I think any static linking test failures
you saw are probably related to #1366 and not the version used to



reply via email to

[Prev in Thread] Current Thread [Next in Thread]