Re: [bug-sourceinstall] Autochecking the options in package configuration

[Nicola Fontana]

On Wed, 25 Jun 2008 00:55:32 +0200
"Claudio Fontana" <address@hidden> wrote:

> I have used g_signal_connect throughout the code, but I would not consider
> myself an expert GTK programmer, and was unaware about this issue.
> I would like to be consistent, by either using g_signal_connect or
> g_signal_connect_object consistently for objects.

I share your view: consistency is an important factor of the
source quality level.

> At the same time, you can see that the objects in sourceinstall-gtk are
> either alive for the whole duration of the program, or they live and die
> in the context of the same function (as in dialog_configure), via
> gtk_dialog_run.
> 
> The fact that the bug in g_signal_connect_object is (still) in the official
> API reference gives me a bad feeling about the API (why not just fix it?)
> 
> http://library.gnome.org/devel/gobject/unstable/gobject-Signals.html#g-signal-connect-object
> 
> Would you still replace all instances of g_signal_connect
> with g_signal_connect_object ?

Given your reasons, now I see g_signal_connect() as the best
option. Anyway I posted a question in the GtkApp mailing list on
this matter.

In any case I attached the reworked patch that use
g_signal_connect(). I also moved the array assignments at the
top of the for() body, to avoid the future surprise of having an
uninitialized array after adding a break or a continue statement
in the middle of the for().

Ciao
-- 
Nicola

autocheck.patch
Description: Text Data