bug-sourceinstall
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-sourceinstall] Autochecking the options in package configuratio


From: Claudio Fontana
Subject: Re: [bug-sourceinstall] Autochecking the options in package configuration
Date: Tue, 24 Jun 2008 21:53:04 +0200

I'd still apply some changes to the patch:

> +static void autocheck(GtkWidget *entry, GtkWidget *check_button)
> +{
> +    const gchar *text;
> +
> +    text = gtk_entry_get_text(entry);
> +
> +    if (text[0] != '\0')
> +     gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (check_button), TRUE);
> +}
> +

the assignment should be text = gtk_entry_get_text(GTK_ENTRY(entry));

As for how the signal is connected, you used the g_signal_connect_object,
but since we run a modal dialog, where entry and check_button will share
the same fate as far as destruction goes (and the g_signal_connect_object
is bugged anyway), I'd replace with a normal g_signal_connect:

g_signal_connect(entry, "changed", G_CALLBACK(autocheck), check_button);

or do you feel strongly about connect_object?

Claudio




reply via email to

[Prev in Thread] Current Thread [Next in Thread]