[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature request/ideas

From: Derek Price
Subject: Re: Feature request/ideas
Date: Mon, 28 Feb 2005 12:41:36 -0500
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

Hash: SHA1

Frank Hemer wrote:

|> The patch looks pretty good.  It's pretty close to what I am
|> doing, except I am splitting tags with operators (.word) on the
|> `.' and then processing the resulting list an element at a time.
|> Thus .prev can be implemented for each and every revision
|> specification type in a single location (as opposed to in a
|> special case inside an `if (commitid)' block.
|> Regardless, what you are doing should mesh pretty well with what
|> I am working on once it has sanity.sh test cases and doc.
| Ooops, I think I'm too fast;-) I have just finished adding '.trunk'
| as a trunk-branch substitution, 'cause I happened to note that this
| fits perfectly into my patch. I have already used the above
| mentioned splitting - so now '.prev' might even be added more than
| once and works perfectly well:-)

Great!  Less work for me.  :)

|> I still think commitids should be cached in val-tags.  Probably
|> as address@hidden' just to keep it short where the user cannot see it
|> anyhow.
| I currently have added this:
| If tags with '@' at the begining are used they're added in the
| cvsnt way (I remember I wrote cvsnt wouldn't cache them but I was
| wrong). If the .commitid is used, they're cached as
| '.commitid.xxx', but this could be changed as you suggested.

I think this would be a good idea, as otherwise the search of val-tags
will be run once for each possible form of the commitid.

Also, commitids should be cached at commit time as well as when they
are found in RCS files.  CVS started doing this on tag creation for
other branches and tags a few releases back  It's silly to wait for
the first update to insert them into val-tags - it only triggers an
unneeded recursive search.

| I'll post my patch after some more cleanups ... soon;-)

Sounds good.  I'm looking forward to seeing your patch!


Version: GnuPG v1.4.0 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]