Re: wget2 | Several OCSP improvements (!513)

[@rockdaboot]

Tim Rühsen commented:


clang-15 is even more picky, but we can care about this later:
```
ssl_openssl.c:530:28: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
        unsigned cert_list_size = sk_X509_num(certs);
                                  ^
/usr/include/openssl/x509.h:76:40: note: expanded from macro 'sk_X509_num'
#define sk_X509_num(sk) OPENSSL_sk_num(ossl_check_const_X509_sk_type(sk))
                                       ^
ssl_openssl.c:533:10: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
                cert = sk_X509_value(certs, i);
                       ^
/usr/include/openssl/x509.h:77:58: note: expanded from macro 'sk_X509_value'
#define sk_X509_value(sk, idx) ((X509 
*)OPENSSL_sk_value(ossl_check_const_X509_sk_type(sk), (idx)))
                                                         ^
ssl_openssl.c:584:56: warning: a function declaration without a prototype is 
deprecated in all versions of C [-Wstrict-prototypes]
static wget_vector *ocsp_create_stapled_response_vector()
                                                       ^
                                                        void
ssl_openssl.c:1063:19: warning: 'ossl_check_const_OPENSSL_STRING_sk_type' was 
marked unused but was used [-Wused-but-marked-unused]
        if (str_stack && sk_OPENSSL_STRING_num(str_stack) > 0) {
                         ^
/usr/include/openssl/safestack.h:206:50: note: expanded from macro 
'sk_OPENSSL_STRING_num'
#define sk_OPENSSL_STRING_num(sk) 
OPENSSL_sk_num(ossl_check_const_OPENSSL_STRING_sk_type(sk))
                                                 ^
ssl_openssl.c:1064:27: warning: 'ossl_check_const_OPENSSL_STRING_sk_type' was 
marked unused but was used [-Wused-but-marked-unused]
                char *uri = wget_strdup(sk_OPENSSL_STRING_value(str_stack, 0));
                                        ^
/usr/include/openssl/safestack.h:207:68: note: expanded from macro 
'sk_OPENSSL_STRING_value'
#define sk_OPENSSL_STRING_value(sk, idx) ((char 
*)OPENSSL_sk_value(ossl_check_const_OPENSSL_STRING_sk_type(sk), (idx)))
                                                                   ^
ssl_openssl.c:1134:29: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
        unsigned cert_chain_size = sk_X509_num(certs), next = starting_idx;
                                   ^
/usr/include/openssl/x509.h:76:40: note: expanded from macro 'sk_X509_num'
#define sk_X509_num(sk) OPENSSL_sk_num(ossl_check_const_X509_sk_type(sk))
                                       ^
ssl_openssl.c:1138:15: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
                candidate = sk_X509_value(certs, next);
                            ^
/usr/include/openssl/x509.h:77:58: note: expanded from macro 'sk_X509_value'
#define sk_X509_value(sk, idx) ((X509 
*)OPENSSL_sk_value(ossl_check_const_X509_sk_type(sk), (idx)))
                                                         ^
ssl_openssl.c:1156:28: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
        unsigned cert_list_size = sk_X509_num(certs);
                                  ^
/usr/include/openssl/x509.h:76:40: note: expanded from macro 'sk_X509_num'
#define sk_X509_num(sk) OPENSSL_sk_num(ossl_check_const_X509_sk_type(sk))
                                       ^
ssl_openssl.c:1159:10: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
                cert = sk_X509_value(certs, i);
                       ^
/usr/include/openssl/x509.h:77:58: note: expanded from macro 'sk_X509_value'
#define sk_X509_value(sk, idx) ((X509 
*)OPENSSL_sk_value(ossl_check_const_X509_sk_type(sk), (idx)))
                                                         ^
ssl_openssl.c:1199:11: warning: variable 'fingerprint' may be uninitialized 
when used here [-Wconditional-uninitialized]
                                xfree(fingerprint);
                                      ^~~~~~~~~~~
./private.h:48:27: note: expanded from macro 'xfree'
#define xfree(a) do { if (a) { wget_free((void *)(a)); a=NULL; } } while (0)
                          ^
ssl_openssl.c:1153:15: note: initialize the variable 'fingerprint' to silence 
this warning
                *fingerprint,
                            ^
                             = NULL
ssl_openssl.c:1281:28: warning: 'ossl_check_const_X509_sk_type' was marked 
unused but was used [-Wused-but-marked-unused]
        vflags->cert_chain_size = sk_X509_num(certs);
                                  ^
/usr/include/openssl/x509.h:76:40: note: expanded from macro 'sk_X509_num'
#define sk_X509_num(sk) OPENSSL_sk_num(ossl_check_const_X509_sk_type(sk))
                                       ^
ssl_openssl.c:1293:2: warning: 'ossl_check_X509_sk_type' was marked unused but 
was used [-Wused-but-marked-unused]
        sk_X509_pop_free(certs, X509_free);
        ^
/usr/include/openssl/x509.h:90:60: note: expanded from macro 'sk_X509_pop_free'
#define sk_X509_pop_free(sk, freefunc) 
OPENSSL_sk_pop_free(ossl_check_X509_sk_type(sk),ossl_check_X509_freefunc_type(freefunc))
                                                           ^
ssl_openssl.c:1293:2: warning: 'ossl_check_X509_freefunc_type' was marked 
unused but was used [-Wused-but-marked-unused]
/usr/include/openssl/x509.h:90:88: note: expanded from macro 'sk_X509_pop_free'
#define sk_X509_pop_free(sk, freefunc) 
OPENSSL_sk_pop_free(ossl_check_X509_sk_type(sk),ossl_check_X509_freefunc_type(freefunc))
                                                                                
       ^
ssl_openssl.c:1732:13: warning: 'ERR_GET_REASON' was marked unused but was used 
[-Wused-but-marked-unused]
                retval = (ERR_GET_REASON(ERR_peek_last_error()) == 
SSL_R_CERTIFICATE_VERIFY_FAILED ?
                          ^
```

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/513#note_1121302987
You're receiving this email because of your account on gitlab.com.