wget-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: wget2 | Several OCSP improvements (!513)


From: @rockdaboot
Subject: Re: wget2 | Several OCSP improvements (!513)
Date: Sat, 01 Oct 2022 11:10:22 +0000



Tim Rühsen commented:


@juaristi 
Code looks good, but could you fix the (gcc) warnings ?
```
ssl_openssl.c:584:21: warning: function declaration isn't a prototype 
[-Wstrict-prototypes]
  584 | static wget_vector *ocsp_create_stapled_response_vector()
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ssl_openssl.c: In function 'ocsp_create_stapled_response_vector':
ssl_openssl.c:584:21: warning: old-style function definition 
[-Wold-style-definition]
ssl_openssl.c: In function 'ocsp_lookup_in_cache':
ssl_openssl.c:639:31: warning: assignment discards 'const' qualifier from 
pointer target type [-Wdiscarded-qualifiers]
  639 |                 *cache_origin = "stapled";
      |                               ^
ssl_openssl.c:653:39: warning: assignment discards 'const' qualifier from 
pointer target type [-Wdiscarded-qualifiers]
  653 |                         *cache_origin = "cached";
```

-- 
Reply to this email directly or view it on GitLab: 
https://gitlab.com/gnuwget/wget2/-/merge_requests/513#note_1121302018
You're receiving this email because of your account on gitlab.com.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]