Re: [Tsp-devel] [PATCH] Fix compilation warnings

[Stephane GALLES]

Frederik Deweerdt wrote:
> On Fri, Nov 09, 2007 at 07:48:00PM +0100, Robert de Vries wrote:
>> On Thursday 08 November 2007 02:55:32 pm Eric Noulard wrote:
>>> 2007/11/6, Robert de Vries <address@hidden>:
>>>> This is the only fix that might not work as it seems that the free
>>>> function was only programmed and never actually called since version
>>>> 1.1 of that file.
>>> All those files "belongs" to Stephane ("Euskadi")
>>> I think you fixes is OK and I think you should commit thoses
>>> unless Stephane steps in and tell us why it may be dangerous
>>> to do so.
>> I didn't hear anything so I checked the patch in. It always possible to 
>> revert 
>> the change.
> Cool! Compiles fine here. BTW, I turned -Wall on and gcc didn't complain
> either.
> 

Very nice job !

Still, since the CruiseControl continuous build on my i386/32bits
desktop builds TSP in vanilla mode, and then in XMLRPC mode, I see some
more warnings in the XMLRPC code that does not show up in the normal
mode (I may have a look to these XMLRPC warnings whenever I have time)

Here is the log of the latest ci build, you can see both builds warnings
(vanilla, and then xmlrpc activated).

---------------------------------

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/ctrl/tsp_group_algo.c:
In function 'TSP_group_algo_create_symbols_table':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/ctrl/tsp_group_algo.c:335:
warning: assignment makes pointer from integer without a cast

conflicts: 1 shift/reduce

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
In function 'tsp_request_sample_init_xmlrpc':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:249:
warning: implicit declaration of function
'xmlrpc_value_to_TSP_request_sample_init'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:249:
warning: assignment makes pointer from integer without a cast

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:259:
warning: implicit declaration of function
'TSP_answer_sample_init_to_xmlrpc_value'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:259:
warning: assignment makes pointer from integer without a cast

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
In function 'tsp_request_sample_destroy_xmlrpc':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:277:
warning: implicit declaration of function
'xmlrpc_value_to_TSP_request_sample_destroy'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:277:
warning: assignment makes pointer from integer without a cast

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:281:
warning: implicit declaration of function
'TSP_answer_sample_destroy_to_xmlrpc_value'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:281:
warning: assignment makes pointer from integer without a cast

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
In function 'TSP_xmlrpc_request':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:292:
warning: assignment from incompatible pointer type

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
At top level:

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:304:
warning: return type defaults to 'int'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
In function 'TSP_xmlrpc_run':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:316:
warning: passing argument 1 of 'atexit' from incompatible pointer type

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:336:
warning: passing argument 5 of 'xmlrpc_registry_add_method' from
incompatible pointer type

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:
In function 'TSP_xmlrpc_request_stop':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/xmlrpc/tsp_xmlrpc_server.c:416:
warning: unused variable 'config'

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/ctrl/tsp_group_algo.c:
In function 'TSP_group_algo_create_symbols_table':

/home/cruise/opt/cruisecontrol-bin-2.6/projects/tsp/src/core/ctrl/tsp_group_algo.c:335:
warning: assignment makes pointer from integer without a cast

conflicts: 1 shift/reduce