Re: [Tsp-devel] [PATCH] Fix compilation warnings

[Frederik Deweerdt]

On Tue, Nov 06, 2007 at 11:19:26PM +0100, Robert de Vries wrote:
Hello Robert,
Thanks for doing this! Useful warnings are often missed when issued in
the middle of pointless ones.
And it is nice, associated with the cmake coloring, I might actually
use an endless loop of tsp compiles as screen saver ;).
[...]
> It would be nice if an actual cmake user would remove the -W -Wall
> flag for the compilation of the generated code.
Out of curiosity, which compiler did you use?

> This would only leave one warning message. (for erk)

Minor comment follows.
[...]
> -     symbolType = gdisp_strDup("F64");
> +     symbolType = BAD_CAST gdisp_strDup("F64");
This and the following gdisp_strDup could be replaced with
xmlCharStrdup(const char *cur) if I'm not mistaken.

Regards,
Frederik