[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] Try using file-attributes cache in file-executable-p, co
From: |
Michael Albinus |
Subject: |
Re: [PATCH 1/1] Try using file-attributes cache in file-executable-p, code refactoring |
Date: |
Tue, 18 Aug 2009 14:12:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Committed.
I have changed the first parameter of `tramp-check-cached-permissions'
to VEC, it is needed by `tramp-get-file-property' and
`tramp-get-connection-property'. In Tramp, it is always "good style" to
use VEC instead of a filename for function parameters; it is needed
often (for example for debug messages).
Furthermore, you go always through the complete (dolist (suffix
'("string" "integer") result) ...) loop. Maybe you could finish when you
have found a hit, using `throw' and `catch'.
Best regards, Michael.
Re: [PATCH 1/1] Try using file-attributes cache in file-executable-p, code refactoring,
Michael Albinus <=