tramp-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] Try using file-attributes cache in file-executable-p, co


From: Julian Scheid
Subject: Re: [PATCH 1/1] Try using file-attributes cache in file-executable-p, code refactoring
Date: Wed, 19 Aug 2009 10:07:56 +1200

On Wed, Aug 19, 2009 at 12:12 AM, Michael Albinus<address@hidden> wrote:
> Committed.

Thanks!

> I have changed the first parameter of `tramp-check-cached-permissions'
> to VEC, it is needed by `tramp-get-file-property' and
> `tramp-get-connection-property'. In Tramp, it is always "good style" to
> use VEC instead of a filename for function parameters; it is needed
> often (for example for debug messages).

Okay.

> Furthermore, you go always through the complete (dolist (suffix
> '("string" "integer") result) ...) loop. Maybe you could finish when you
> have found a hit, using `throw' and `catch'.

There's an "or" condition on the result at the beginning that will
prevent the second iteration if the first iteration led to a hit.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]