[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Inserting spaces in output from -E

From: Michael Matz
Subject: Re: [Tinycc-devel] Inserting spaces in output from -E
Date: Thu, 5 May 2016 18:19:05 +0200 (CEST)
User-agent: Alpine 2.20 (LSU 67 2015-01-07)


On Thu, 5 May 2016, David Mertens wrote:

wtf is this? Commit fe845cf is huge, and looks like it's messing with a lot. You may know what you're doing, but onlookers will observe your behavior and think, "Oh, it's OK if I push a huge, opinionated changeset to mob without discussion." I don't think this is the kind of culture you want to encourage around tcc development. In particular, you should have split these changes across multiple commits and put a little more explanation into what you're doing in the commit messages. You also should avoid removal of command-line options without discussion.

Well, it was introduced without discussion to start with, so this aspect is IMHO okay.

Just as a point of context, I am now maintaining the exsymtab work as a fork of the current mob, so any changes that are made have to be merged. In other words, I'm a downstream consumer of tcc. This morning I got a merge conflict with these define print functions that you removed.

The functions were moved, not removed. The rest of the patch cleans up code sensibly, so I think all is well (well, the passing of pp_debug_{tok,symv} is a bit hands-on :) ).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]