[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Inserting spaces in output from -E

From: David Mertens
Subject: Re: [Tinycc-devel] Inserting spaces in output from -E
Date: Thu, 5 May 2016 09:01:13 -0400


wtf is this? Commit fe845cf is huge, and looks like it's messing with a lot. You may know what you're doing, but onlookers will observe your behavior and think, "Oh, it's OK if I push a huge, opinionated changeset to mob without discussion." I don't think this is the kind of culture you want to encourage around tcc development. In particular, you should have split these changes across multiple commits and put a little more explanation into what you're doing in the commit messages. You also should avoid removal of command-line options without discussion.

Just as a point of context, I am now maintaining the exsymtab work as a fork of the current mob, so any changes that are made have to be merged. In other words, I'm a downstream consumer of tcc. This morning I got a merge conflict with these define print functions that you removed. I sure am glad you happened to mention this work off-hand, or I would have had no idea why I had a conflict.

More conversation is better in this context.

On Thu, May 5, 2016 at 8:21 AM, grischka <address@hidden> wrote:
Vladimir Vissoultchev wrote: ---
One remark: I believe in the tcc_preprocess routine s1->ppfp is always set, otherwise it wouldn't have been called.

I think it can be NULL when dffp is set for the dflag output when dumping
defines only (w/o actual preprocessor output).

There is no dffp.

Nor is there any -E output from outside of tcc_preprocess, in
particular not from within the input file parser. ;)


-- gr


Tinycc-devel mailing list

 "Debugging is twice as hard as writing the code in the first place.
  Therefore, if you write the code as cleverly as possible, you are,
  by definition, not smart enough to debug it." -- Brian Kernighan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]