[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Tinycc-devel] Several patchs from Debian packaging

From: grischka
Subject: Re: [Tinycc-devel] Several patchs from Debian packaging
Date: Tue, 20 Apr 2010 21:16:52 +0200
User-agent: Thunderbird (Windows/20090812)

RoboTux wrote:
I also changed the load/save_buffer_state horrible hack into a dynarray approach. Take a look at the code, I'm sure you'll be happy with it.

Yes, happy!

I guess these 6 lines:
    file_name = tcc_malloc(sizeof(char) * (strlen(filename) + 1));
    strcpy(file_name, filename);
    dynarray_add((void ***) &libs, &nblibs, file_name);
    lib_name = tcc_malloc(sizeof(char) * (strlen(libname) + 1));
    strcpy(lib_name, libname);
    dynarray_add((void ***) &libs, &nblibs, lib_name);

are logically equal to these 2 lines:
    dynarray_add((void ***) &libs, &nblibs, tcc_strdup(filename));
    dynarray_add((void ***) &libs, &nblibs, tcc_strdup(libname));

But then again I'm a perfectionist ;)

--- grischka

reply via email to

[Prev in Thread] Current Thread [Next in Thread]