[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sysvinit-devel] [PATCH 2/5] init.c: add return tests for dup() in s

From: Michał Kulling
Subject: Re: [sysvinit-devel] [PATCH 2/5] init.c: add return tests for dup() in spawn()
Date: Tue, 11 Feb 2014 20:46:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Hi Petter!

Could you apply patch from attachment?

I added four new variables at the top of spawn() for TTY controlling and duplicated /dev/null.

Coverity mark my changes as resource leak because I'm not assign descriptor returned from dup().

Patch for rev 159.

Best regards, Mike.

[Michał Kulling]
Currently in spawn() function is using dup() without return code
validation, i added simple check with additional output to stderr.
Thank you.  Applied.

Michal Kulling

Attachment: init.c_patch1_11022014.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]