[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [sysvinit-devel] [PATCH 2/5] init.c: add return tests for dup() in s

From: Petter Reinholdtsen
Subject: Re: [sysvinit-devel] [PATCH 2/5] init.c: add return tests for dup() in spawn()
Date: Tue, 11 Feb 2014 22:30:46 +0100
User-agent: Mutt/1.5.20 (2009-12-10)

[Michał Kulling]
> Coverity mark my changes as resource leak because I'm not assign
> descriptor returned from dup().

No, it mark them as resource leaks because the resources leak.  The
opened file descriptor isn't closed.  I suspect things will fail it it
is closed, so I have not tried to close it.  But I have not
investigated either.

The previous patch made it easier to see in Coverity exactly where
things go wrong, which is why I applied them.  Did you expect them to
get rid of the leak?

Happy hacking
Petter Reinholdtsen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]