[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[STUMP] [PATCH] Remove group-window-visible-p.

From: Ben Spencer
Subject: [STUMP] [PATCH] Remove group-window-visible-p.
Date: Tue, 27 Oct 2009 21:03:21 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

This method is pretty pointless because it does exactly the same as
window-visible-p, but has an extra (unused) parameter.  It was also
never implemented for floating groups, which caused bug #25055.  I've
removed the method and replaced the one call to it with a call to
 events.lisp     |    2 +-
 tile-group.lisp |    3 ---
 2 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/events.lisp b/events.lisp
index 6f36c5b..fc6205e 100644
--- a/events.lisp
+++ b/events.lisp
@@ -495,7 +495,7 @@ converted to an atom is removed."
   (if (deny-request-p window *deny-raise-request*)
       (unless (or *suppress-deny-messages*
                   ;; don't mention windows that are already visible
-                  (group-window-visible-p (window-group window) window))
+                  (window-visible-p window))
         (if (eq (window-group window) (current-group))
             (echo-string (window-screen window) (format nil "'~a' denied raise 
request" (window-name window)))
             (echo-string (window-screen window) (format nil "'~a' denied raise 
request in group ~a" (window-name window) (group-name (window-group window))))))
diff --git a/tile-group.lisp b/tile-group.lisp
index ed2fcb6..710cfde 100644
--- a/tile-group.lisp
+++ b/tile-group.lisp
@@ -127,9 +127,6 @@
     (focus-all where)
-(defmethod group-window-visible-p ((group tile-group) win)
-  (eq (frame-window (window-frame win)) win))
 (defmethod group-root-exposure ((group tile-group))
   (show-frame-outline group nil))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]