Re: [Simulavr-devel] build fails

[D. Laszlo Sitzer]

Hi Petr,

thanks for your fix. I have tried to build once again but it still
fails with a (smaller) error message related to systemclock.cpp

/bin/bash ../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H
-I.    -I/usr/include -g -O2 -Icmd -Iui -Ihwtimer -MT systemclock.lo
-MD -MP -MF .deps/systemclock.Tpo -c -o systemclock.lo systemclock.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I/usr/include -g -O2 -Icmd
-Iui -Ihwtimer -MT systemclock.lo -MD -MP -MF .deps/systemclock.Tpo -c
systemclock.cpp  -fPIC -DPIC -o .libs/systemclock.o
systemclock.cpp: In member function ‘void MinHeap<Key, Value>::RemoveMinimum()’:
systemclock.cpp:48: error: there are no arguments to ‘empty’ that
depend on a template parameter, so a declaration of ‘empty’ must be
available
systemclock.cpp:48: note: (if you use ‘-fpermissive’, G++ will accept
your code, but allowing the use of an undeclared name is deprecated)
systemclock.cpp: In member function ‘void MinHeap<Key,
Value>::RemoveMinimumAndInsert(Key, Value)’:
systemclock.cpp:89: error: there are no arguments to ‘empty’ that
depend on a template parameter, so a declaration of ‘empty’ must be
available
make[3]: *** [systemclock.lo] Error 1

before building I ran "make clean distclean; ./bootstrap; ./configure; make"

thank you (and address@hidden) for your help,

lazlo

On Wed, Dec 14, 2011 at 11:01 PM, Petr Hluzín <address@hidden> wrote:
> On 12 December 2011 15:12, D. Laszlo Sitzer <address@hidden> wrote:
> ...
>> I'm using the following software/versions:
>>
>> kernel 2.6.35-31-generic x86_64
>> gcc (Ubuntu/Linaro 4.4.4-14ubuntu5) 4.4.5
>> autoconf (GNU Autoconf) 2.67
>> automake (GNU automake) 1.11.1
>> GNU Make 3.81
>> GNU bash, version 4.1.5(1)-release (x86_64-pc-linux-gnu)
>>
>> Is there anything else I could provide (files, information) that might
>> be helpful to identify the problem?
>>
>> The last version I have successfully built was "a49e8da". I will try
>> to run some builds on revisions just before "9712eea" (latest) an see
>> if that might help.
>
> There is no need for you to try building older revisions. Thanks for
> the offer, though. I know the code and the build failure was
> introduced by me in the last commit.
>
> Little background: Originally the code used std::multimap. However
> simulavr usually has only 1 element in it and removing and adding
> caused the multimap to always free and then allocate an internal
> block. I tried to use std::vector with STL's make_heap() but I did not
> figure out how to write the comparison function (we need minimum heap,
> STL does maximum heap by default).
>
> You seem to have called ./bootstrap successfully.
>
> Fixed in 
> http://git.savannah.gnu.org/cgit/simulavr.git/commit/?id=a06b58f0f73f2c8e659284eba56489a67b9fc024
>
> --
> Petr Hluzin