Re: [Simulavr-devel] Patch

[Theodore A. Roth]

On Wed, 13 Aug 2003, Hermann Kraus wrote:

> Hello everybody!
>
> I've created a new patch for simulavr. It's mostly the same as I've posted
> some month ago, but it's better tested (thanks to Andreas Buhr
> <address@hidden>) and it contains the files that where missing in the
> last patch. It also contains one improvement by Andreas Buhr. I think
> (hope?) that the patch is quite stable and could perhaps be used for an new
> release.

The patch won't apply:

address@hidden:~/dev/tools/simulavr-cvs$ patch -p1 --dry-run < 
complete_patch.diff
patching file ChangeLog
patch: **** malformed patch at line 196: Index:
simulavr/doc/simulavr.texi

If I remove the ChangeLog entry from the patch, I get past that error,
but the patch will not apply to the latest cvs.

Unless the patch came be applied to the latest cvs, I'm not too likely
to even consider committing it.

Also, this is a huge patch which could be split into a lot of smaller
patches. For example, documentation fixes and additions should be one
patch.

When adding new functionality, the patch should be distilled down to
the bare minmum to add that feature. This makes review easier.

Also, try avoid the urge to reformat the code. It just litters the
patch with changes that distract from the stated goal of the patch.

Ted Roth