[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Rdiff-backup-bugs] [bug #24100] Can't specify the root directory ('c:\'

From: Anders Hellstrand
Subject: [Rdiff-backup-bugs] [bug #24100] Can't specify the root directory ('c:\') as src in native win32 binary.
Date: Thu, 09 Oct 2008 19:57:52 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; sv-SE; rv: Gecko/2008092417 Firefox/3.0.3

Follow-up Comment #19, bug #24100 (project rdiff-backup):


Thanks for the explanation of "Windows-long-path-names-with-spaces-in". Great
- both that it works and that it is already supported!

Regarding my testcase with "two::colon" it was just the worst possible names
choosen by me, it should have been written as "server::path" of course and
that passes the test (both with and without the patch).

I didn't know that :: was allowed in linux file names, but of course then the
.split method is a bad way to do it.

Take your time and give the proposed patch a second thought because I still
think that it may solve the problem. The only thing that the patch does is
that if a trailing slash exist in the string, rdiff-backup will not go thru
the following lines where the out of range error occur.
The only drawback i can think of, and you may know if there are a use case
there, is if there is a good reason to raise an error if a trailing slash
exists when used from Linux. (I suspect that the already existing error
handling are there for a reason?).
It may be neccessary to have a linux case and a windows case with an OS check
as in some other places of the code to allow/disallow a trailing slash?

BR / Anders


Reply to this item at:


  Meddelandet skickades via/av Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]