Re: [Quilt-dev] [PATCH] Fix handling of patch files with ':' in their name.

[Jean Delvare]

Le dimanche 02 décembre 2012 à 10:49 +0100, Martin Quinson a écrit :
> > > -                              -a ! -path "$path/.timestamp" |
> > > -               sed -e "s:$path/::"
> > > +                              -a ! -path "$path/.timestamp" \
> > > +                              -printf "%P\n"
> > 
> > I can't remember the policy in quilt, but I can't find evidence, that
> > -printf is in the POSIX standard yet.
> 
> I'm not sure we have an official policy here, but I'd say that we are
> pragmatic concerning the portability: we want quilt to be usable on
> all platforms that are still used nowadays.

That's correct. We already rely on find -path and -print0 options which
aren't in the POSIX standard either AFAICS. Which basically means that
anyone who wants to use quilt already needs find from GNU findutils, or
an equally powerful BSD alternative.

That being said, while BSD implementations of find do support -path and
-print0, they don't seem to support -printf. Even though I'm not using
BSD myself, I believe this is a good enough reason to not use -printf if
we can avoid it.

> Unless someone objects, I think I'll commit this change; if it breaks
> something for an exotic platform at some point, we'll think further:
> either revert the change or come up with a better one.

I object ;) Satoru has proposed an alternative, which seems a bit costly
performance-wise, but that can probably be improved.

> Thanks for your time guys: quilt really needs people to propose
> patches and other ones to comment them in order to keep going forward.

Oh yes :) I'm reviewing the recent submissions today and will comment
and/or commit them. Unless Martin is faster, of course.

-- 
Jean Delvare
Suse L3